[Merged by Bors] - refactor(Algebra/Homology): use the new homology API#8706
Closed
[Merged by Bors] - refactor(Algebra/Homology): use the new homology API#8706
Conversation
11 tasks
Member
This part of you message seems to have swapped some lefts and rights. |
jcommelin
approved these changes
Nov 30, 2023
Contributor
|
✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
delegated
Co-authored-by: Johan Commelin <[email protected]>
Contributor
Author
|
Thanks very much @jcommelin for all these reviews! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
This PR refactors the construction of left derived functors using the new homology API: this also affects the dependencies (Ext functors, group cohomology, local cohomology). As a result, the old homology API is no longer used in any significant way in mathlib. Then, with this PR, the homology refactor is essentially complete. The organization of the files was made more coherent: the definition of a projective resolution is in `Preadditive.ProjectiveResolution`, the existence of resolutions when there are enough projectives is shown in `Abelian.ProjectiveResolution`, and the left derived functor is constructed in `Abelian.LeftDerived`; the dual results are in `Preadditive.InjectiveResolution`, `Abelian.InjectiveResolution` and `Abelian.RightDerived`. Co-authored-by: Joël Riou <[email protected]>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
This PR refactors the construction of left derived functors using the new homology API: this also affects the dependencies (Ext functors, group cohomology, local cohomology). As a result, the old homology API is no longer used in any significant way in mathlib. Then, with this PR, the homology refactor is essentially complete. The organization of the files was made more coherent: the definition of a projective resolution is in `Preadditive.ProjectiveResolution`, the existence of resolutions when there are enough projectives is shown in `Abelian.ProjectiveResolution`, and the left derived functor is constructed in `Abelian.LeftDerived`; the dual results are in `Preadditive.InjectiveResolution`, `Abelian.InjectiveResolution` and `Abelian.RightDerived`. Co-authored-by: Joël Riou <[email protected]>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the construction of left derived functors using the new homology API: this also affects the dependencies (Ext functors, group cohomology, local cohomology). As a result, the old homology API is no longer used in any significant way in mathlib. Then, with this PR, the homology refactor is essentially complete.
The organization of the files was made more coherent: the definition of a projective resolution is in
Preadditive.ProjectiveResolution, the existence of resolutions when there are enough projectives is shown inAbelian.ProjectiveResolution, and the left derived functor is constructed inAbelian.LeftDerived; the dual results are inPreadditive.InjectiveResolution,Abelian.InjectiveResolutionandAbelian.RightDerived.