[Merged by Bors] - feat: two homotopic maps of short complexes induce the same map in homology#8079
Closed
[Merged by Bors] - feat: two homotopic maps of short complexes induce the same map in homology#8079
Conversation
11 tasks
jcommelin
reviewed
Nov 1, 2023
Comment on lines
+645
to
+667
| lemma congr_leftHomologyMap' (h : Homotopy φ₁ φ₂) (h₁ : S₁.LeftHomologyData) | ||
| (h₂ : S₂.LeftHomologyData) : leftHomologyMap' φ₁ h₁ h₂ = leftHomologyMap' φ₂ h₁ h₂ := by | ||
| rw [h.eq_add_nullHomotopic, leftHomologyMap'_add, leftHomologyMap'_nullHomotopic, add_zero] | ||
|
|
||
| lemma congr_rightHomologyMap' (h : Homotopy φ₁ φ₂) (h₁ : S₁.RightHomologyData) | ||
| (h₂ : S₂.RightHomologyData) : rightHomologyMap' φ₁ h₁ h₂ = rightHomologyMap' φ₂ h₁ h₂ := by | ||
| rw [h.eq_add_nullHomotopic, rightHomologyMap'_add, rightHomologyMap'_nullHomotopic, add_zero] | ||
|
|
||
| lemma congr_homologyMap' (h : Homotopy φ₁ φ₂) (h₁ : S₁.HomologyData) | ||
| (h₂ : S₂.HomologyData) : homologyMap' φ₁ h₁ h₂ = homologyMap' φ₂ h₁ h₂ := by | ||
| rw [h.eq_add_nullHomotopic, homologyMap'_add, homologyMap'_nullHomotopic, add_zero] | ||
|
|
||
| lemma congr_leftHomologyMap (h : Homotopy φ₁ φ₂) [S₁.HasLeftHomology] [S₂.HasLeftHomology] : | ||
| leftHomologyMap φ₁ = leftHomologyMap φ₂ := | ||
| h.congr_leftHomologyMap' _ _ | ||
|
|
||
| lemma congr_rightHomologyMap (h : Homotopy φ₁ φ₂) [S₁.HasRightHomology] [S₂.HasRightHomology] : | ||
| rightHomologyMap φ₁ = rightHomologyMap φ₂ := | ||
| h.congr_rightHomologyMap' _ _ | ||
|
|
||
| lemma congr_homologyMap (h : Homotopy φ₁ φ₂) [S₁.HasHomology] [S₂.HasHomology] : | ||
| homologyMap φ₁ = homologyMap φ₂ := | ||
| h.congr_homologyMap' _ _ |
Member
There was a problem hiding this comment.
I think I would put the congr at the end of the name, instead of at the start. I feel like that way there also a bigger chance of discovering it via autocompletion when searching for names about leftHomologyMap etc...
What do you think?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. I have made congr a suffix here.
jcommelin
added
awaiting-author
joelriou
added
awaiting-review
and removed
awaiting-author
ghost
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.