[Merged by Bors] - refactor: introduce the new homology API for homological complex and rename the old one#7954
Closed
[Merged by Bors] - refactor: introduce the new homology API for homological complex and rename the old one#7954
Conversation
11 tasks
joelriou
changed the title
jcommelin
approved these changes
Oct 27, 2023
Member
jcommelin
left a comment
jcommelin
left a comment
There was a problem hiding this comment.
LGTM, modulo 1 comment.
bors d+
|
✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
delegated
Co-authored-by: Johan Commelin <[email protected]>
Contributor
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
…rename the old one (#7954) This PR renames definitions of the current homology API (adding a `'` to `homology`, `cycles`, `QuasiIso`) so as to create space for the development of the new homology API of homological complexes: this PR also contains the new definition of `HomologicalComplex.homology` which involves the homology theory of short complexes. Co-authored-by: Joël Riou <[email protected]>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
grunweg
pushed a commit
that referenced
this pull request
Nov 1, 2023
…rename the old one (#7954) This PR renames definitions of the current homology API (adding a `'` to `homology`, `cycles`, `QuasiIso`) so as to create space for the development of the new homology API of homological complexes: this PR also contains the new definition of `HomologicalComplex.homology` which involves the homology theory of short complexes. Co-authored-by: Joël Riou <[email protected]>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames definitions of the current homology API (adding a
'tohomology,cycles,QuasiIso) so as to create space for the development of the new homology API of homological complexes: this PR also contains the new definition ofHomologicalComplex.homologywhich involves the homology theory of short complexes.Next, the plan is to develop this new homology API, and then make small PRs which remove the downstream uses of the old homology API, replacing these with the new API. Significant steps will include refactors of projective/injective resolutions and left/right derived functors. Enabling the use of the new homology API in the development of group cohomology is also important. (Eventually, when the old API is no longer used and when old statements all have equivalents in the new homology API, it could be removed.)