[Merged by Bors] - refactor(LinearAlgebra/QuadraticForm/Basic): remove non-commutativity support#7581
Closed
eric-wieser wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - refactor(LinearAlgebra/QuadraticForm/Basic): remove non-commutativity support#7581eric-wieser wants to merge 5 commits intomasterfrom
eric-wieser wants to merge 5 commits intomasterfrom
Conversation
… support As discussed [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/Quadratic.20Maps/near/395529867), this generalization seems nonsensical as currently implemented.
eric-wieser
added
awaiting-review
awaiting-CI
1 task
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
delegated
github-actions
bot
removed
the
awaiting-CI
Contributor
|
Thanks! bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
… support (#7581) As discussed [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/Quadratic.20Maps/near/395529867), this generalization seems nonsensical as currently implemented. There are sensible ways to make this generalization, but they are much larger refactors, and in the meantime the current generalization is useless anyway.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Zulip, this generalization seems nonsensical as currently implemented.
There are sensible ways to make this generalization, but they are much larger refactors, and in the meantime the current generalization is useless anyway.