Skip to content

[Merged by Bors] - feat: the pretriangulated structure on the opposite category#7336

Closed
joelriou wants to merge 13 commits intomasterfrom
pretriangulated-op
Closed

[Merged by Bors] - feat: the pretriangulated structure on the opposite category#7336
joelriou wants to merge 13 commits intomasterfrom
pretriangulated-op

Conversation

@joelriou
Copy link
Copy Markdown
Contributor


(I also have a proof of the octahedron axiom, but compatibilites are still a bit messy.)

Open in Gitpod

@joelriou joelriou added WIP Work in progress t-category-theory Category theory labels Sep 23, 2023
@joelriou joelriou added awaiting-review and removed WIP Work in progress labels Sep 23, 2023

/-- The pretriangulated structure on the opposite category of
a pretriangulated category. -/
scoped instance : Pretriangulated Cᵒᵖ where
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this instance need to be scoped? Can you please document that here, or add a link to some library note that explains it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I have added a comment.

@erdOne erdOne added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Oct 17, 2023
@joelriou joelriou added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Oct 18, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Oct 20, 2023
@bors
Copy link
Copy Markdown

bors bot commented Oct 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: the pretriangulated structure on the opposite category [Merged by Bors] - feat: the pretriangulated structure on the opposite category Oct 20, 2023
@bors bors bot closed this Oct 20, 2023
@bors bors bot deleted the pretriangulated-op branch October 20, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants