Skip to content

[Merged by Bors] - chore: use fast_instance% in classes of continuous maps#37629

Closed
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_lintContClasses
Closed

[Merged by Bors] - chore: use fast_instance% in classes of continuous maps#37629
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_lintContClasses

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel commented Apr 4, 2026


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

PR summary 4ecd8b17db

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : AddGroup C_c(α, β) := fast_instance%
+ instance [AddCommGroup β] [IsTopologicalAddGroup β] : AddCommGroup C_c(α, β) := fast_instance%
+ instance [AddCommMonoid β] [ContinuousAdd β] : AddCommMonoid C_c(α, β) := fast_instance%
+ instance [AddMonoid β] [ContinuousAdd β] : AddMonoid C_c(α, β) := fast_instance%
+ instance [AddZeroClass β] [ContinuousAdd β] : AddZeroClass C_c(α, β) := fast_instance%
+ instance [CommMonoid β] [ContinuousMul β] : CommMonoid C(α, β) := fast_instance%
+ instance [CommMonoidWithZero β] [ContinuousMul β] : CommMonoidWithZero C(α, β) := fast_instance%
+ instance [CommSemigroup β] [ContinuousMul β] : CommSemigroup C(α, β) := fast_instance%
+ instance [Group β] [IsTopologicalGroup β] : Group C(α, β) := fast_instance%
+ instance [Monoid β] [ContinuousMul β] : Monoid C(α, β) := fast_instance%
+ instance [MonoidWithZero β] [ContinuousMul β] : MonoidWithZero C(α, β) := fast_instance%
+ instance [MulOneClass β] [ContinuousMul β] : MulOneClass C(α, β) := fast_instance%
+ instance [MulZeroClass β] [ContinuousMul β] : MulZeroClass C(α, β) := fast_instance%
+ instance [MulZeroClass β] [ContinuousMul β] : MulZeroClass C_c(α, β) := fast_instance%
+ instance [NonUnitalRing β] [IsTopologicalRing β] : NonUnitalRing C_c(α, β) := fast_instance%
+ instance [Semigroup β] [ContinuousMul β] : Semigroup C(α, β) := fast_instance%
+ instance [SemigroupWithZero β] [ContinuousMul β] : SemigroupWithZero C(α, β) := fast_instance%
+-+- semilatticeInf
+-+- semilatticeSup
- instance : AddGroup C_c(α, β)
- instance [AddCommGroup β] [IsTopologicalAddGroup β] : AddCommGroup C_c(α, β)
- instance [AddCommMonoid β] [ContinuousAdd β] : AddCommMonoid C_c(α, β)
- instance [AddMonoid β] [ContinuousAdd β] : AddMonoid C_c(α, β)
- instance [AddZeroClass β] [ContinuousAdd β] : AddZeroClass C_c(α, β)
- instance [CommMonoid β] [ContinuousMul β] : CommMonoid C(α, β)
- instance [CommMonoidWithZero β] [ContinuousMul β] : CommMonoidWithZero C(α, β)
- instance [CommSemigroup β] [ContinuousMul β] : CommSemigroup C(α, β)
- instance [Group β] [IsTopologicalGroup β] : Group C(α, β)
- instance [Monoid β] [ContinuousMul β] : Monoid C(α, β)
- instance [MonoidWithZero β] [ContinuousMul β] : MonoidWithZero C(α, β)
- instance [MulOneClass β] [ContinuousMul β] : MulOneClass C(α, β)
- instance [MulZeroClass β] [ContinuousMul β] : MulZeroClass C(α, β)
- instance [MulZeroClass β] [ContinuousMul β] : MulZeroClass C_c(α, β)
- instance [NonUnitalRing β] [IsTopologicalRing β] : NonUnitalRing C_c(α, β)
- instance [Semigroup β] [ContinuousMul β] : Semigroup C(α, β)
- instance [SemigroupWithZero β] [ContinuousMul β] : SemigroupWithZero C(α, β)
-++- partialOrder

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Apr 4, 2026
Copy link
Copy Markdown
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 5, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: use fast_instance% in classes of continuous maps [Merged by Bors] - chore: use fast_instance% in classes of continuous maps Apr 5, 2026
@mathlib-bors mathlib-bors bot closed this Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants