Skip to content

feat(topology): Small inductive dimension#37619

Open
FernandoChu wants to merge 10 commits intoleanprover-community:masterfrom
FernandoChu:SmallIndDim
Open

feat(topology): Small inductive dimension#37619
FernandoChu wants to merge 10 commits intoleanprover-community:masterfrom
FernandoChu:SmallIndDim

Conversation

@FernandoChu
Copy link
Copy Markdown
Collaborator

@FernandoChu FernandoChu commented Apr 3, 2026

Adds a type class for small inductive dimension. See also #37444.

Co-authored-by: Andrew Yang [email protected]

AI disclosure: Claude code assisted in preparing this PR.

Open in Gitpod

@FernandoChu FernandoChu requested a review from vihdzp April 3, 2026 20:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026 •
edited
Loading

PR summary 7d837a8020

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.SmallInductiveDimension (new file) 733

Declarations diff

+ HasSmallInductiveDimensionLE
+ HasSmallInductiveDimensionLT_one_iff
+ HasSmallInductiveDimensionLT_zero_iff
+ inductive
+ smallInductiveDimension

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Apr 3, 2026
@vihdzp
Copy link
Copy Markdown
Collaborator

vihdzp commented Apr 3, 2026

It seems a bit weird to me to have a typeclass for "small inductive dimension less than", but not an actual definition for the small inductive dimension.

@FernandoChu
Copy link
Copy Markdown
Collaborator Author

FernandoChu commented Apr 3, 2026

I was following the sSet case, but this seems to be the exception, not the norm. I've added a def, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vihdzp vihdzp Awaiting requested review from vihdzp

Assignees

No one assigned

Labels

t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FernandoChu @vihdzp