Skip to content

feat: pushing Lattice and predecessors through Equiv#37605

Open
Parcly-Taxel wants to merge 1 commit intoleanprover-community:masterfrom
Parcly-Taxel:equiv-lattice
Open

feat: pushing Lattice and predecessors through Equiv#37605
Parcly-Taxel wants to merge 1 commit intoleanprover-community:masterfrom
Parcly-Taxel:equiv-lattice

Conversation

@Parcly-Taxel
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

PR summary cd8272a9d5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ distribLattice
+ lattice
+ le
+ le_def
+ linearOrder
+ lt
+ lt_def
+ max
+ max_def
+ min
+ min_def
+ ord
+ ord_def
+ partialOrder
+ preorder
+ semilatticeInf
+ semilatticeSup

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Parcly-Taxel Parcly-Taxel requested a review from YaelDillies April 3, 2026 17:03
@vihdzp
Copy link
Copy Markdown
Collaborator

vihdzp commented Apr 3, 2026

Doesn't this just duplicate what we can already do with the Function.Injective constructors?

@Parcly-Taxel
Copy link
Copy Markdown
Collaborator Author

Doesn't this just duplicate what we can already do with the Function.Injective constructors?

Yaël asked me to do this. See #36934 (comment).

Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants