Skip to content

refactor(Data.Finset.*Antidiagonal): rename set-based defs to set*Antidiagonal#37593

Open
IlPreteRosso wants to merge 2 commits intoleanprover-community:masterfrom
IlPreteRosso:setMulAntidiagonal-rename
Open

refactor(Data.Finset.*Antidiagonal): rename set-based defs to set*Antidiagonal#37593
IlPreteRosso wants to merge 2 commits intoleanprover-community:masterfrom
IlPreteRosso:setMulAntidiagonal-rename

Conversation

@IlPreteRosso
Copy link
Copy Markdown
Contributor

@IlPreteRosso IlPreteRosso commented Apr 3, 2026 •
edited
Loading

Renames set-based Finset.mulAntidiagonal → setMulAntidiagonal (and SMul/VAdd variants) to free the mulAntidiagonal name for the planned HasMulAntidiagonal typeclass. Deprecation aliases added.

Supersedes #34551

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026 •
edited
Loading

PR summary 6ef8cc2731

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ isPWO_support_setMulAntidiagonal
+ isPWO_support_setSMulAntidiagonal
+ mem_setMulAntidiagonal
+ mem_setSMulAntidiagonal
+ setMulAntidiagonal
+ setMulAntidiagonal_min_mul_min
+ setMulAntidiagonal_mono_left
+ setMulAntidiagonal_mono_right
+ setSMulAntidiagonal
+ setSMulAntidiagonal_min_smul_min
+ setSMulAntidiagonal_mono_left
+ setSMulAntidiagonal_mono_right
+ support_setMulAntidiagonal_subset_mul
+ support_setSMulAntidiagonal_subset_smul
+ swap_mem_setMulAntidiagonal

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-ring-theory Ring theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@IlPreteRosso