Skip to content

feat: set up API for ConvexSpace#37592

Open
erdOne wants to merge 13 commits intoleanprover-community:masterfrom
erdOne:erd1/APIConvexSpace
Open

feat: set up API for ConvexSpace#37592
erdOne wants to merge 13 commits intoleanprover-community:masterfrom
erdOne:erd1/APIConvexSpace

Conversation

@erdOne
Copy link
Copy Markdown
Member

@erdOne erdOne commented Apr 3, 2026

We introduce sConvexCombo and the indexed version iConvexCombo as the main API for ConvexSpace and prove lemmas around the new definitions.


Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Apr 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

PR summary 79463c8311

Import changes exceeding 2%

% File
+9.35% Mathlib.LinearAlgebra.ConvexSpace

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.LinearAlgebra.ConvexSpace 770 842 +72 (+9.35%)
Mathlib.LinearAlgebra.ConvexSpace.AffineSpace 1021 1005 -16 (-1.57%)
Mathlib.Analysis.Convex.MetricSpace 1475 1474 -1 (-0.07%)
Import changes for all files
Files Import difference
Mathlib.LinearAlgebra.ConvexSpace.AffineSpace -16
Mathlib.Analysis.Convex.MetricSpace -1
Mathlib.LinearAlgebra.ConvexSpace 72

Declarations diff

+ ConvexSpace.IsMetricCompatible
+ ConvexSpace.IsMetricCompatible.of_convex
+ ConvexSpace.mk
+ ConvexSpace.ofConvex.coe_iConvexCombo
+ ConvexSpace.ofConvex.coe_sConvexCombo
+ IsAffineMap
+ IsAffineMap.comp
+ IsAffineMap.id
+ IsAffineMap.map_convexComboPair
+ IsAffineMap.map_iConvexCombo
+ StdSimplex.isAffineMap_map
+ StdSimplex.isAffineMap_weights
+ convexComboPair_convexComboPair_assoc_left
+ convexComboPair_convexComboPair_assoc_right
+ convexComboPair_convexComboPair_left_eq_sConvexCombo
+ convexComboPair_convexComboPair_right_eq_sConvexCombo
+ convexComboPair_def
+ convexComboPair_eq_add
+ convexComboPair_iConvexCombo_iConvexCombo
+ convexComboPair_iConvexCombo_left
+ convexComboPair_iConvexCombo_right
+ dist_iConvexCombo_le
+ dist_iConvexCombo_left_le
+ dist_iConvexCombo_right_le
+ dist_sConvexCombo_left_le
+ dist_sConvexCombo_right_le
+ iConvexCombo
+ iConvexCombo_comm
+ iConvexCombo_congr
+ iConvexCombo_const
+ iConvexCombo_convexComboPair
+ iConvexCombo_convexComboPair_comm
+ iConvexCombo_convexComboPair_comm_left
+ iConvexCombo_convexComboPair_comm_right
+ iConvexCombo_eq_affineCombination
+ iConvexCombo_eq_sum
+ iConvexCombo_iConvexCombo
+ iConvexCombo_id
+ iConvexCombo_id'
+ iConvexCombo_map
+ iConvexCombo_single
+ instance : ConvexSpace R (StdSimplex R I)
+ isAffineMap_coe
+ isAffineMap_convexComboPair
+ join_join
+ join_single
+ map_iConvexCombo
+ map_join
+ map_sConvexCombo
+ sConvexCombo_eq_affineCombination
+ sConvexCombo_eq_sum
+ sConvexCombo_sConvexCombo
+ weights_nonneg
+ weights_sConvexCombo
- ConvexSpace.ofConvex.coe_convexCombination
- IsConvexMetricSpace
- IsConvexMetricSpace.of_convex
- _root_.convexCombination_eq_sum
- dist_convexCombination_left_le
- dist_convexCombination_map_le
- dist_convexCombination_right_le

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 3, 2026
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants