Skip to content

[Merged by Bors] - chore: remove a backward.inferInstanceAs.wrap false#37586

Closed
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_removeBack
Closed

[Merged by Bors] - chore: remove a backward.inferInstanceAs.wrap false#37586
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_removeBack

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel commented Apr 3, 2026


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

PR summary 28f63a901b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : Fintype (X q) := inferInstanceAs <| Fintype (ZMod q × ZMod q)
- instance : Fintype (X q) := inferInstanceAs (Fintype (ZMod q × ZMod q))

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.25)
Current number Change Type
4 -1 backward.inferInstanceAs.wrap

Current commit a2f373b9e0
Reference commit 28f63a901b

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Apr 3, 2026
@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

LGTM, but maybe somebody who knows more about the transparency stuff can have another look.

maintainer merge?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

🚀 Pull request has been placed on the maintainer queue by MichaelStollBayreuth.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 4, 2026
Copy link
Copy Markdown
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 5, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove a backward.inferInstanceAs.wrap false [Merged by Bors] - chore: remove a backward.inferInstanceAs.wrap false Apr 5, 2026
@mathlib-bors mathlib-bors bot closed this Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants