Skip to content

feat(Combinatorics/SimpleGraph/Walk): upgrade subset theorems to sublist/prefix/suffix#37577

Open
SnirBroshi wants to merge 1 commit intoleanprover-community:masterfrom
SnirBroshi:feature/simple-graph/walk/support-sublist-prefix-suffix
Open

feat(Combinatorics/SimpleGraph/Walk): upgrade subset theorems to sublist/prefix/suffix#37577
SnirBroshi wants to merge 1 commit intoleanprover-community:masterfrom
SnirBroshi:feature/simple-graph/walk/support-sublist-prefix-suffix

Conversation

@SnirBroshi
Copy link
Copy Markdown
Collaborator

Upgrades theorems about p.support ⊆ q.support / p.darts ⊆ q.darts / p.edges ⊆ q.edges
to List.IsInfix/List.IsSuffix/List.Sublist, which imply the subset versions.


I did not add such theorems where there was no subset theorem to begin with (e.g. (p.take n).darts <+: p.darts), as they are usually not worth stating since they're trivial and simp proves them.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

PR summary c7cd377ce0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ darts_bypass_sublist
+ darts_dropUntil_suffix
+ darts_takeUntil_prefix
+ edges_bypass_sublist
+ edges_dropUntil_suffix
+ edges_takeUntil_prefix
+ support_bypass_sublist
+ support_dropUntil_suffix
+ support_prefix_support_append
+ support_prefix_support_concat
+ support_suffix_support_append
+ support_suffix_support_cons
+ support_takeUntil_prefix

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-combinatorics Combinatorics label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant