Skip to content

[Merged by Bors] - feat: Iic 2 = {0, 1, 2}#37557

Closed
vihdzp wants to merge 4 commits intoleanprover-community:masterfrom
vihdzp:Iio_two
Closed

[Merged by Bors] - feat: Iic 2 = {0, 1, 2}#37557
vihdzp wants to merge 4 commits intoleanprover-community:masterfrom
vihdzp:Iio_two

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Apr 2, 2026


Open in Gitpod

@vihdzp vihdzp added the t-order Order theory label Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

PR summary 1a79483f50

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Order.Monoid.Canonical.Defs 194 195 +1 (+0.52%)
Import changes for all files
Files Import difference
102 files Mathlib.Algebra.ContinuedFractions.Computation.Basic Mathlib.Algebra.Group.PNatPowAssoc Mathlib.Algebra.Order.AbsoluteValue.Basic Mathlib.Algebra.Order.AbsoluteValue.Euclidean Mathlib.Algebra.Order.AddGroupWithTop Mathlib.Algebra.Order.Algebra Mathlib.Algebra.Order.BigOperators.Group.List Mathlib.Algebra.Order.BigOperators.Group.Multiset Mathlib.Algebra.Order.BigOperators.Ring.List Mathlib.Algebra.Order.BigOperators.Ring.Multiset Mathlib.Algebra.Order.Field.Canonical Mathlib.Algebra.Order.Field.Power Mathlib.Algebra.Order.Floor.Defs Mathlib.Algebra.Order.Group.Nat Mathlib.Algebra.Order.GroupWithZero.Canonical Mathlib.Algebra.Order.GroupWithZero.Lex Mathlib.Algebra.Order.GroupWithZero.WithZero Mathlib.Algebra.Order.Hom.MonoidWithZero Mathlib.Algebra.Order.Hom.Ring Mathlib.Algebra.Order.Invertible Mathlib.Algebra.Order.Kleene Mathlib.Algebra.Order.Module.Algebra Mathlib.Algebra.Order.Module.Field Mathlib.Algebra.Order.Monoid.Associated Mathlib.Algebra.Order.Monoid.Canonical.Defs Mathlib.Algebra.Order.Monoid.Prod Mathlib.Algebra.Order.Monoid.ToMulBot Mathlib.Algebra.Order.Monoid.TypeTags Mathlib.Algebra.Order.Monoid.WithTop Mathlib.Algebra.Order.Nonneg.Floor Mathlib.Algebra.Order.PUnit Mathlib.Algebra.Order.Pi Mathlib.Algebra.Order.Ring.Abs Mathlib.Algebra.Order.Ring.Canonical Mathlib.Algebra.Order.Ring.Cast Mathlib.Algebra.Order.Ring.Nat Mathlib.Algebra.Order.Ring.Pow Mathlib.Algebra.Order.Ring.Prod Mathlib.Algebra.Order.Ring.WithTop Mathlib.Algebra.Order.Sub.Basic Mathlib.Algebra.Order.WithTop.Untop0 Mathlib.Algebra.Ring.BooleanRing Mathlib.Algebra.Ring.Identities Mathlib.Algebra.Ring.Subring.Order Mathlib.Algebra.Tropical.Basic Mathlib.Combinatorics.Quiver.Path.Decomposition Mathlib.Combinatorics.Quiver.Path.Vertices Mathlib.Control.Fix Mathlib.Data.Bool.Count Mathlib.Data.Int.AbsoluteValue Mathlib.Data.Int.Order.Lemmas Mathlib.Data.Int.Order.Units Mathlib.Data.List.Iterate Mathlib.Data.Multiset.DershowitzManna Mathlib.Data.Multiset.OrderedMonoid Mathlib.Data.Nat.BitIndices Mathlib.Data.Nat.Cast.Order.Ring Mathlib.Data.Nat.Dist Mathlib.Data.Nat.Upto Mathlib.Data.Num.Lemmas Mathlib.Data.Num.Prime Mathlib.Data.Num.ZNum Mathlib.Data.Ordmap.Invariants Mathlib.Data.Ordmap.Ordset Mathlib.Data.PNat.Basic Mathlib.Data.PNat.Factors Mathlib.Data.PNat.Find Mathlib.Data.PNat.Prime Mathlib.Data.PNat.Xgcd Mathlib.Data.Rat.Sqrt Mathlib.Data.String.Basic Mathlib.RingTheory.Coprime.Basic Mathlib.SetTheory.Lists Mathlib.Tactic.Bound Mathlib.Tactic.CancelDenoms Mathlib.Tactic.FieldSimp.Discharger Mathlib.Tactic.FieldSimp Mathlib.Tactic.Field Mathlib.Tactic.Finiteness Mathlib.Tactic.Group Mathlib.Tactic.Linarith.Datatypes Mathlib.Tactic.Linarith.Frontend Mathlib.Tactic.Linarith.Lemmas Mathlib.Tactic.Linarith.Oracle.FourierMotzkin Mathlib.Tactic.Linarith.Oracle.SimplexAlgorithm Mathlib.Tactic.Linarith.Parsing Mathlib.Tactic.Linarith.Preprocessing Mathlib.Tactic.Linarith.Verification Mathlib.Tactic.LinearCombination' Mathlib.Tactic.LinearCombination Mathlib.Tactic.NormNum.Abs Mathlib.Tactic.NormNum.DivMod Mathlib.Tactic.NormNum.Ineq Mathlib.Tactic.NormNum.ModEq Mathlib.Tactic.PNatToNat Mathlib.Tactic.Positivity.Basic Mathlib.Tactic.Positivity.Core Mathlib.Tactic.Positivity Mathlib.Tactic.Qify Mathlib.Tactic.Ring.Compare Mathlib.Tactic.Ring.PNat Mathlib.Tactic.Ring
1

Declarations diff

+ Iic_one
+ Iic_two
+ Iio_one
+ Iio_two
+ isEmpty_Iio_one
- instIsEmptyIioZero

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Collaborator

@artie2000 artie2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

Comment thread Mathlib/Algebra/Order/Monoid/Canonical/Defs.lean Outdated
Copy link
Copy Markdown
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 5, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Iic 2 = {0, 1, 2} [Merged by Bors] - feat: Iic 2 = {0, 1, 2} Apr 5, 2026
@mathlib-bors mathlib-bors bot closed this Apr 5, 2026
riccardobrasca pushed a commit to riccardobrasca/mathlib4 that referenced this pull request Apr 6, 2026
YellPika pushed a commit to YellPika/mathlib4 that referenced this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants