feat: another version of the cardinality of the difference#37541
Open
EtienneC30 wants to merge 1 commit intoleanprover-community:masterfrom
Open
feat: another version of the cardinality of the difference#37541EtienneC30 wants to merge 1 commit intoleanprover-community:masterfrom
EtienneC30 wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary c7cd377ce0Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In mathlib there is
Set.ncard_diffwhich states that(t \ s).ncard = t.ncard - s.ncardwhens ⊆ tandsis finite. But one way to prove thatsis finite is by showing thattis finite and using thes ⊆ thypothesis, so this PR addsSet.ncard_diff'which assumes thattis finite instead ofs.