Skip to content

feat(Algebra/Category/ModuleCat/Sheaf): isQuasicoherent and isFinitePresentation are closed under isomorphisms#37532

Open
justus-springer wants to merge 1 commit intoleanprover-community:masterfrom
justus-springer:justus/quasicoherent_closed_under_iso
Open

feat(Algebra/Category/ModuleCat/Sheaf): isQuasicoherent and isFinitePresentation are closed under isomorphisms#37532
justus-springer wants to merge 1 commit intoleanprover-community:masterfrom
justus-springer:justus/quasicoherent_closed_under_iso

Conversation

@justus-springer
Copy link
Copy Markdown
Collaborator


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

PR summary 28f63a901b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ QuasicoherentData.of_isIso
+ instance (σ : M.GeneratingSections) (p : M ⟶ N) [Epi p] [σ.IsFiniteType] :
+ instance : (isFinitePresentation R).IsClosedUnderIsomorphisms
+ instance : (isQuasicoherent R).IsClosedUnderIsomorphisms
+ instance {M N : SheafOfModules.{u} R} (f : M ⟶ N) [IsIso f]
+ instance {M N : SheafOfModules.{u} R} (f : M ⟶ N) [IsIso f] (σ : M.QuasicoherentData)

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant