fix(Topology/Algebra): fix bad simps and make arguments implicit for PointwiseConvergenceCLM#37530
Open
mcdoll wants to merge 3 commits intoleanprover-community:masterfrom
Open
fix(Topology/Algebra): fix bad simps and make arguments implicit for PointwiseConvergenceCLM#37530mcdoll wants to merge 3 commits intoleanprover-community:masterfrom
PointwiseConvergenceCLM#37530mcdoll wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
PR summary 4ec5d95aa6Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 6889 | -6 | backward.isDefEq.respectTransparency |
Current commit a682c2caae
Reference commit 4ec5d95aa6
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We delete all
simpscalls in the definitions of operators onPointwiseConvergenceCLMand replace them withapply_applylemmas that do not abuse the defeq betweenSLₚₜandSL. This made the linter discover some typeclass duplications, which we remove by restructuring the file.As a consequence of the new
simplemmas, we can remove allset_option backward.isDefEq.respectTransparency false ininAnalysis.Distribution.TemperedDistribution.Moreover, we make several arguments implicit, which can be inferred in almost all practical situations.