Skip to content

[Merged by Bors] - chore(Combinatorics/SimpleGraph/Coloring): move Coloring.lean to Coloring/VertexColoring.lean#37525

Closed
SnirBroshi wants to merge 2 commits intoleanprover-community:masterfrom
SnirBroshi:chore/simple-graph/coloring/create-folder
Closed

[Merged by Bors] - chore(Combinatorics/SimpleGraph/Coloring): move Coloring.lean to Coloring/VertexColoring.lean#37525
SnirBroshi wants to merge 2 commits intoleanprover-community:masterfrom
SnirBroshi:chore/simple-graph/coloring/create-folder

Conversation

@SnirBroshi
Copy link
Copy Markdown
Collaborator

@SnirBroshi SnirBroshi commented Apr 1, 2026

This is in preparation of #33313 and other material to come, here's how I imagine the folder to look like:

  • Coloring/VertexColoring.lean (currently Coloring.lean)
  • Coloring/EdgeColoring.lean
  • Coloring/VertexListColoring.lean
  • Coloring/EdgeListColoring.lean
  • Coloring/ChromaticPolynomial.lean
  • Coloring/EdgeLabeling.lean (currently ./EdgeLabeling.lean)
  • Coloring/ConcreteColorings.lean (currently ./ConcreteColorings.lean)

I'll add module deprecations in a follow-up.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

PR summary 71bf6f4ba4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Combinatorics.SimpleGraph.Coloring -797
Mathlib.Combinatorics.SimpleGraph.Coloring.VertexColoring 797

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

note: file Mathlib/Combinatorics/SimpleGraph/Coloring.lean` was renamed to `Mathlib/Combinatorics/SimpleGraph/Coloring/VertexColoring.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

@github-actions github-actions bot added file-removed A Lean module was (re)moved without a `deprecated_module` annotation t-combinatorics Combinatorics labels Apr 1, 2026
@ooovi ooovi requested a review from YaelDillies April 2, 2026 07:49
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 2, 2026
…oloring/VertexColoring.lean` (#37525)

This is in preparation of #33313 and other material to come, here's how I imagine the folder to look like:
- `Coloring/VertexColoring.lean` (currently `Coloring.lean`)
- `Coloring/EdgeColoring.lean`
- `Coloring/VertexListColoring.lean`
- `Coloring/EdgeListColoring.lean`
- `Coloring/ChromaticPolynomial.lean`
- `Coloring/EdgeLabeling.lean` (currently `./EdgeLabeling.lean`)
- `Coloring/ConcreteColorings.lean` (currently `./ConcreteColorings.lean`)
@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 2, 2026
@YaelDillies
Copy link
Copy Markdown
Contributor

What about instead:

  • Coloring.Vertex
  • Coloring.Edge
  • Coloring.VertexList
  • Coloring.EdgeList
  • Coloring.ChromaticPolynomial
  • Coloring.EdgeLabeling
  • Coloring.Concrete

@ooovi
Copy link
Copy Markdown
Collaborator

ooovi commented Apr 2, 2026

Could you move EdgeLabelling and ConcreteColorings too, while you're at it? Thanks :)

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Combinatorics/SimpleGraph/Coloring): move Coloring.lean to Coloring/VertexColoring.lean [Merged by Bors] - chore(Combinatorics/SimpleGraph/Coloring): move Coloring.lean to Coloring/VertexColoring.lean Apr 2, 2026
@mathlib-bors mathlib-bors bot closed this Apr 2, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 3, 2026
…oloring/VertexColoring.lean` (leanprover-community#37525)

This is in preparation of leanprover-community#33313 and other material to come, here's how I imagine the folder to look like:
- `Coloring/VertexColoring.lean` (currently `Coloring.lean`)
- `Coloring/EdgeColoring.lean`
- `Coloring/VertexListColoring.lean`
- `Coloring/EdgeListColoring.lean`
- `Coloring/ChromaticPolynomial.lean`
- `Coloring/EdgeLabeling.lean` (currently `./EdgeLabeling.lean`)
- `Coloring/ConcreteColorings.lean` (currently `./ConcreteColorings.lean`)
riccardobrasca pushed a commit to riccardobrasca/mathlib4 that referenced this pull request Apr 6, 2026
…oloring/VertexColoring.lean` (leanprover-community#37525)

This is in preparation of leanprover-community#33313 and other material to come, here's how I imagine the folder to look like:
- `Coloring/VertexColoring.lean` (currently `Coloring.lean`)
- `Coloring/EdgeColoring.lean`
- `Coloring/VertexListColoring.lean`
- `Coloring/EdgeListColoring.lean`
- `Coloring/ChromaticPolynomial.lean`
- `Coloring/EdgeLabeling.lean` (currently `./EdgeLabeling.lean`)
- `Coloring/ConcreteColorings.lean` (currently `./ConcreteColorings.lean`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

file-removed A Lean module was (re)moved without a `deprecated_module` annotation ready-to-merge This PR has been sent to bors. t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants