Skip to content

feat(Analysis/InnerProductSpace): singleton basis for 1d space#37506

Open
wwylele wants to merge 16 commits intoleanprover-community:masterfrom
wwylele:orth-basis-single
Open

feat(Analysis/InnerProductSpace): singleton basis for 1d space#37506
wwylele wants to merge 16 commits intoleanprover-community:masterfrom
wwylele:orth-basis-single

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Apr 1, 2026

This was brought up in #36462. Similar to existing FiniteDimensional.basisSingleton, this provides a OrthonormalBasis version.

Open in Gitpod

@wwylele wwylele mentioned this pull request Apr 1, 2026
Open
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026 •
edited
Loading

PR summary c0ee2a9375

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Subsingleton.forall₂
+ orthonormalBasisSingleton
+ orthonormalBasisSingleton_apply
+ orthonormalBasisSingleton_repr_apply
+ orthonormal_subsingleton_iff
+ range_orthonormalBasisSingleton
+ toBasis_orthonormalBasisSingleton

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Apr 1, 2026
eric-wieser
eric-wieser reviewed Apr 1, 2026
View reviewed changes
@wwylele wwylele force-pushed the orth-basis-single branch from 9ea4a31 to 08ea425 Compare April 1, 2026 20:47
themathqueen
themathqueen reviewed Apr 2, 2026
View reviewed changes
themathqueen
themathqueen reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also add the lemma for orthonormalBasisSingleton_repr_apply (see FiniteDimensional.basisSingleton_repr_apply for the basis version) and maybe also a version of FiniteDimensional.range_basisSingleton?

@themathqueen themathqueen added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
loefflerd
loefflerd reviewed Apr 3, 2026
View reviewed changes
@wwylele wwylele force-pushed the orth-basis-single branch from a33ba4b to c1838f3 Compare April 3, 2026 19:20
themathqueen
themathqueen reviewed Apr 3, 2026
View reviewed changes
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Apr 3, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
themathqueen
themathqueen reviewed Apr 3, 2026
View reviewed changes
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Apr 3, 2026

Ok I guess I need to fix some simp problem in downstream...
awaiting-author

@github-actions github-actions bot added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Apr 3, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
themathqueen
themathqueen approved these changes Apr 4, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

loefflerd
loefflerd reviewed Apr 4, 2026
View reviewed changes
loefflerd
loefflerd approved these changes Apr 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@loefflerd loefflerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me too. I was a little nervous about the new simp lemma needing changes elsewhere in the library – one does not lightly modify the root note in the import tree! – but in fact all the changes downstream seem to be beneficial, so I think we're good.

@loefflerd
Copy link
Copy Markdown
Contributor

loefflerd commented Apr 4, 2026

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@loefflerd loefflerd loefflerd approved these changes

@themathqueen themathqueen themathqueen approved these changes

Assignees

@loefflerd loefflerd

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-analysis Analysis (normed *, calculus)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wwylele @loefflerd @eric-wieser @themathqueen