Skip to content

chore(*): remove comments mentioning obsolete note [nolint_ge]#37503

Open
Vierkantor wants to merge 1 commit intoleanprover-community:masterfrom
Vierkantor:remove-nolint_ge
Open

chore(*): remove comments mentioning obsolete note [nolint_ge]#37503
Vierkantor wants to merge 1 commit intoleanprover-community:masterfrom
Vierkantor:remove-nolint_ge

Conversation

@Vierkantor
Copy link
Copy Markdown
Contributor

In Lean 3 times we used to have a ge_or_gt linter which complained if theorem statements contained or >, and it would be silenced with a reference to the library note [nolint_ge]. But the linter and its note never got ported, so the references are irrelevant and we should drop them.


Open in Gitpod

In Lean 3 times we used to have a `ge_or_gt` linter which complained if theorem statements contained `≥` or `>`, and it would be silenced with a reference to the library note `[nolint_ge]`. But the linter and its note never got ported, so the references are irrelevant and we should drop them.
@Vierkantor Vierkantor added t-linter Linter tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

PR summary 551ca8f603

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Apr 1, 2026

I have an (old) PR porting the linter: #12879 --- that got stalled because there was no decision if we still want the linter.

My understanding is that

  • simp and rw might be fine now
  • rw? is sensitive to flipping the order; I don't remember about exact?
    The latter might be reason enough to still keep the current mathlib convention (and then we might as well enforce it using a linter). What do you think?

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Apr 1, 2026

If there is agreement that the linter is desirable, I'm happy to dust off my PR. I don't have spoons this week to start a discussion about this, though.

@Vierkantor
Copy link
Copy Markdown
Contributor Author

I don't recall seeing issues with tactics failing to unify < and > since we switched over to Lean 4. Looking at your old PR, there don't seem to be any proofs that got better due to getting rid of >. So right now I'm unconvinced we want the linter. But if you have some practical example where > breaks things and < does not, then I'd change my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-linter Linter tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants