[Merged by Bors] - fix: remove @[reducible] attribute from Function.injective#375
Closed
dwrensha wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - fix: remove @[reducible] attribute from Function.injective#375dwrensha wants to merge 1 commit intoleanprover-community:masterfrom
dwrensha wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
Member
Author
|
I have low confidence about exactly what's going on in |
Member
For the record, that's because lemmas like
No, they're fine. They're controlling reduction of something else, namely the type. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2022
In mathlib3, [`function.injective`](https://github.com/leanprover-community/lean/blob/4b58f26becf336a50cf037c3e2894b6f2938956e/library/init/function.lean#L73) is not reducible, so `Function.injective` should not be reducible here either. To avoid errors in `Order/Basic` ("@[ext] attribute only applies to structures or lemmas proving x = y"), we need to adjust `extAttribute` too. Fixes some problems seen in #372.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In mathlib3,
function.injectiveis not reducible, soFunction.injectiveshould not be reducible here either.To avoid errors in
Order/Basic("@[ext] attribute only applies to structures or lemmas proving x = y"), we need to adjustextAttributetoo.Fixes some problems seen in #372.