[Merged by Bors] - chore(Order): make CompleteDistribLattice.MinimalAxioms.of semireducible#37478
Closed
YaelDillies wants to merge 2 commits intoleanprover-community:masterfrom
Closed
Conversation
…cible This is part of the greater discussion about whether we should make all `def`s appearing in instances `implicit_reducible`. I believe the answer in this case is pretty clearly yes sinced the sole purpose of `CompleteLattice.MinimalAxioms` is to build instances. From APAP
PR summary 5289bf289aImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Vierkantor
approved these changes
Apr 15, 2026
Contributor
Vierkantor
left a comment
Vierkantor
left a comment
There was a problem hiding this comment.
Makes sense to me!
bors merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
…cible (#37478) This is part of the greater discussion about whether we should make all `def`s appearing in instances `implicit_reducible`. I believe the answer in this case is pretty clearly yes sinced the sole purpose of `CompleteLattice.MinimalAxioms` is to build instances. From APAP
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
CompleteDistribLattice.MinimalAxioms.of semireducibleCompleteDistribLattice.MinimalAxioms.of semireducible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the greater discussion about whether we should make all
defs appearing in instancesimplicit_reducible. I believe the answer in this case is pretty clearly yes sinced the sole purpose ofCompleteLattice.MinimalAxiomsis to build instances.From APAP