Skip to content

feat(RingTheory/MvPolynomial/MonomialOrder): add leadingTerm_mul lemma#37471

Open
NoahW314 wants to merge 3 commits intoleanprover-community:masterfrom
NoahW314:leadingTerm
Open

feat(RingTheory/MvPolynomial/MonomialOrder): add leadingTerm_mul lemma#37471
NoahW314 wants to merge 3 commits intoleanprover-community:masterfrom
NoahW314:leadingTerm

Conversation

@NoahW314
Copy link
Copy Markdown
Contributor

@NoahW314 NoahW314 commented Apr 1, 2026


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

PR summary db1186dd23

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ leadingTerm_mul

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@WilliamCoram WilliamCoram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Copy link
Copy Markdown
Contributor

@Maldooor Maldooor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Do you also maybe want to write corresponding leadingTerm_add and leadingTerm_sub lemmas? Those could be a part of this PR or you could open another one.

@NoahW314
Copy link
Copy Markdown
Contributor Author

NoahW314 commented Apr 1, 2026

Sure, I can work on adding those in a later PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants