Skip to content

[Merged by Bors] - feat(SetTheory/Ordinal): add add_iSup, mul_iSup and friends#37470

Closed
SabrinaJewson wants to merge 3 commits intoleanprover-community:masterfrom
SabrinaJewson:ordinal-limits
Closed

[Merged by Bors] - feat(SetTheory/Ordinal): add add_iSup, mul_iSup and friends#37470
SabrinaJewson wants to merge 3 commits intoleanprover-community:masterfrom
SabrinaJewson:ordinal-limits

Conversation

@SabrinaJewson
Copy link
Copy Markdown
Contributor

@SabrinaJewson SabrinaJewson commented Apr 1, 2026 •
edited
Loading

Add a couple lemmas for working with ordinal iSup and sSup, addition and multiplication.

Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026 •
edited
Loading

PR summary 7d9358ee9d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ add_iSup
+ add_sSup
+ ciSup_bot
+ mul_iSup
+ mul_sSup

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

SnirBroshi
SnirBroshi reviewed Apr 1, 2026
View reviewed changes
SnirBroshi
SnirBroshi reviewed Apr 1, 2026
View reviewed changes
@vihdzp vihdzp self-assigned this Apr 1, 2026
@vihdzp vihdzp added the t-set-theory Set theory label Apr 1, 2026
@vihdzp
Copy link
Copy Markdown
Collaborator

vihdzp commented Apr 1, 2026

I'm currently working hard on removing Ordinal.lsub, see my PR series #36940 → #37064 → #37262. So please don't add any more API to it!

vihdzp
vihdzp reviewed Apr 1, 2026
View reviewed changes
@vihdzp
Copy link
Copy Markdown
Collaborator

vihdzp commented Apr 1, 2026

Can we also have sSup versions of these?

@vihdzp vihdzp added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 1, 2026
@SabrinaJewson SabrinaJewson mentioned this pull request Apr 1, 2026
Closed
@SabrinaJewson
Copy link
Copy Markdown
Contributor Author

SabrinaJewson commented Apr 2, 2026

I added sSup versions. But in doing so, I made a bunch of other changes to conditionally complete lattices, which I put in a separate PR that this PR now is rebased on: #37526.

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 2, 2026
vihdzp
vihdzp reviewed Apr 2, 2026
View reviewed changes
vihdzp
vihdzp approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this looks good to me. Though you might want to remove the changes from #37526 since your PR no longer depends on them.

vihdzp
vihdzp reviewed Apr 4, 2026
View reviewed changes
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 4, 2026
@vihdzp vihdzp removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 4, 2026
@vihdzp
Copy link
Copy Markdown
Collaborator

vihdzp commented Apr 4, 2026

Oh, can you update the PR desc too, so it doesn't mention lsub? Thanks!

@vihdzp vihdzp requested a review from YaelDillies April 4, 2026 17:10
YaelDillies
YaelDillies approved these changes Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 5, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Apr 5, 2026

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 5, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2026
@SabrinaJewson
feat(SetTheory/Ordinal): add add_iSup, mul_iSup and friends (#37470)
5a1c5fc 
Add a couple lemmas for working with ordinal `iSup` and `sSup`, addition and multiplication.

Co-authored-by: SabrinaJewson <[email protected]>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(SetTheory/Ordinal): add add_iSup, mul_iSup and friends [Merged by Bors] - feat(SetTheory/Ordinal): add add_iSup, mul_iSup and friends Apr 5, 2026
@mathlib-bors mathlib-bors bot closed this Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

+2 more reviewers

@SnirBroshi SnirBroshi SnirBroshi left review comments

@vihdzp vihdzp vihdzp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vihdzp vihdzp

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SabrinaJewson @vihdzp @riccardobrasca @YaelDillies @SnirBroshi