Skip to content

fix(FunProp): be less strict about the shape of morphism theorems#37441

Open
lecopivo wants to merge 3 commits intoleanprover-community:masterfrom
lecopivo:fun_prop_attr_check_fix
Open

fix(FunProp): be less strict about the shape of morphism theorems#37441
lecopivo wants to merge 3 commits intoleanprover-community:masterfrom
lecopivo:fun_prop_attr_check_fix

Conversation

@lecopivo
Copy link
Copy Markdown
Collaborator

@lecopivo lecopivo commented Mar 31, 2026 •
edited by grunweg
Loading

Don't be so restrictive about the shape of morphism theorems

Right now, fun_prop has a problem with a bundled morphism Foo α that coerces to α → α → α . The coerced function has two arguments and there is an unnecessary restriction about this. This PR lifts that restriction.

Zulip discussion

Open in Gitpod

@github-actions github-actions bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-meta Tactics, attributes or user commands labels Mar 31, 2026
@lecopivo lecopivo force-pushed the fun_prop_attr_check_fix branch from c7934ac to 6b450dd Compare March 31, 2026 14:45
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

PR summary d4d96de5f1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ FooHom
+ con_foohom'
+ instance : FunLike (FooHom α) α (α → α)

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

t-meta Tactics, attributes or user commands

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lecopivo @skrivantomas