chore(Algebra/Pointwise): generalise closure_pow_le#37431
Open
YaelDillies wants to merge 2 commits intoleanprover-community:masterfrom
Open
chore(Algebra/Pointwise): generalise closure_pow_le#37431YaelDillies wants to merge 2 commits intoleanprover-community:masterfrom
closure_pow_le#37431YaelDillies wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
Thanks to Andrew for spotting this.
PR summary 1a37cd3c8eImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
reviewed
Mar 31, 2026
| variable {s t u : Set M} | ||
|
|
||
| @[to_additive] | ||
| @[to_additive (attr := simp)] |
Contributor
There was a problem hiding this comment.
Can you say why this is fine? We have been cautious about adding conditional simp lemmas. (Same below.)
Contributor
There was a problem hiding this comment.
please address this when you have a moment (only saying this because I saw you responded to the other comment).
grunweg
reviewed
Mar 31, 2026
j-loreaux
added
the
awaiting-author
YaelDillies
removed
the
awaiting-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to Andrew for spotting this.