refactor: change definitions to avoid ConvexCone#37420
Open
artie2000 wants to merge 2 commits intoleanprover-community:masterfrom
Open
refactor: change definitions to avoid ConvexCone#37420artie2000 wants to merge 2 commits intoleanprover-community:masterfrom
ConvexCone#37420artie2000 wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 96c77b07ff
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Geometry.Convex.Cone.Pointed | 1070 | 1071 | +1 (+0.09%) |
| Mathlib.Analysis.Convex.Cone.Closure | 1178 | 1179 | +1 (+0.08%) |
Import changes for all files
| Files | Import difference |
|---|---|
10 filesMathlib.Analysis.Convex.Cone.Basic Mathlib.Analysis.Convex.Cone.Closure Mathlib.Analysis.Convex.Cone.Dual Mathlib.Analysis.Convex.Cone.InnerDual Mathlib.Analysis.Convex.Cone.TensorProduct Mathlib.Geometry.Convex.Cone.DualFinite Mathlib.Geometry.Convex.Cone.Dual Mathlib.Geometry.Convex.Cone.Pointed Mathlib.Geometry.Convex.Cone.Simplicial Mathlib.Geometry.Convex.Cone.TensorProduct |
1 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
6 tasks
vihdzp
approved these changes
Mar 31, 2026
ooovi
approved these changes
Apr 2, 2026
YaelDillies
approved these changes
Apr 2, 2026
Contributor
YaelDillies
left a comment
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks! 🚀
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
mathlib-triage
bot
added
the
maintainer-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the definitions of
PointedCone.positiveandPointedCone.closureto avoid mentioningConvexCone.This PR is part of a series deprecating
ConvexCone: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Replacing.20.60ConvexCone.60.20with.20.60PointedCone.60/with/582738985