[Merged by Bors] - chore(RatFunc/Luroth): split file and small changes#37397
Closed
xgenereux wants to merge 4 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(RatFunc/Luroth): split file and small changes#37397xgenereux wants to merge 4 commits intoleanprover-community:masterfrom
xgenereux wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
xgenereux
added
the
easy
PR summary b301d257a1Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
|
what are the "small changes"? Since the file was split, the diff doesnt show on github properly |
xgenereux
removed
the
easy
Collaborator
Author
|
You can look at the the individual commits, I just mean that I removed the notation. |
1 task
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2026
This PR splits the Luroth file so that we can use the results on `IntermediateField` without having to import the whole file. I've also applied some small changes like removing the custom notation in favor of the more general `Algebra.adjoin` notation. Co-authored-by: Xavier Genereux <[email protected]>
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
mathlib-bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the Luroth file so that we can use the results on
IntermediateFieldwithout having to import the whole file.I've also applied some small changes like removing the custom notation in favor of the more general
Algebra.adjoinnotation.