feat(FunctionField): constant extensions are finite#37388
Open
xgenereux wants to merge 8 commits intoleanprover-community:masterfrom
Open
feat(FunctionField): constant extensions are finite#37388xgenereux wants to merge 8 commits intoleanprover-community:masterfrom
xgenereux wants to merge 8 commits intoleanprover-community:masterfrom
Conversation
PR summary 47ed25d3caImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
This pull request has conflicts, please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let
Fbe a function field overFq. IfEis an algebraic extension ofFqwhich is contained inFthen it is finite overFq.To implement this, we model the following tower of extensions:
by assuming algebra hypotheses on the level of
Fq[X]andE[X]and usetogether with the scoped
RatFuncinstancesRatFunc.liftAlgebraandRatFunc.isScalarTower_liftAlgebrato obtain the appropriate algebra instances fromRatFunc Fq/E.One annoying thing is that using these instances creates a diamond with
RatFunc.instSMulOfFractionRingPolynomial, I am working on trying to find a fix but don't have anything at the moment. I am open to suggestions!Here are some details on this diamond:
Since both
RatFunc EandFractionRing E[X](which are not defeq) have anIsFractionRing E[X]instance we get two maps coming fromRatFunc.liftAlgebra:Where the first one is transported back to
RatFunc EviaRatFunc.instSMulOfFractionRingPolynomial. Analyzingwe see that this boils down to
{ toFractionRing := (IsLocalization.lift ⋯) x } = (IsFractionRing.lift ⋯) xnot being defeq.Co-authored-by: María Inés de Frutos Fernández <[email protected]>