refactor(Algebra/Order): unbundle group and ring cone#37298
Open
artie2000 wants to merge 4 commits intoleanprover-community:masterfrom
Open
refactor(Algebra/Order): unbundle group and ring cone#37298artie2000 wants to merge 4 commits intoleanprover-community:masterfrom
artie2000 wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
github-actions
bot
added
the
large-import
PR summary e960b84129Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Order.Group.Cone | 348 | 657 | +309 (+88.79%) |
| Mathlib.Algebra.Order.Ring.Cone | 414 | 690 | +276 (+66.67%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Order.Ring.Cone |
276 |
Mathlib.Algebra.Order.Group.Cone |
309 |
Declarations diff
+ IsOrderedMonoid.mkOfSubmonoid
+ IsOrderedRing.mkOfSubsemiring
+ LinearOrder.mkOfSubmonoid
+ PartialOrder.mkOfSubmonoid
+ PartialOrder.mkOfSubmonoid_le_iff
+ Submonoid.oneLE.isMulPointed
+ Submonoid.oneLE.isMulSpanning
+ Subsemiring.nonneg.isPointed
+ Subsemiring.nonneg.isSpanning
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
Increase in tech debt: (relative, absolute) = (3.00, 0.19)
| Current number | Change | Type |
|---|---|---|
| 16 | 3 | disabled deprecation lints |
Current commit 0d93da52fd
Reference commit e960b84129
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Collaborator
Author
|
What is the right way to fix the warnings? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GroupConeandRingConeusingSubmonoid.IsMulPointed