Skip to content

[Merged by Bors] - feat(Topology/Order): existence of a sequence that converges to limsup#37296

Closed
CoolRmal wants to merge 19 commits intoleanprover-community:masterfrom
CoolRmal:liminfsubseq
Closed

[Merged by Bors] - feat(Topology/Order): existence of a sequence that converges to limsup#37296
CoolRmal wants to merge 19 commits intoleanprover-community:masterfrom
CoolRmal:liminfsubseq

Conversation

@CoolRmal
Copy link
Copy Markdown
Contributor

@CoolRmal CoolRmal commented Mar 28, 2026

The PR establishes the following results:

  1. The limsSup of a filter f is a cluster point of f, and in fact it is the greatest cluster point of f.
  2. If f is a countably generated filter in a first countable space, then there exists a sequence converging to limsSup f.
  3. Analogous statements for limsup are also proved.
  4. Analogous statements for limsInf and liminf are also proved.

Zulip discussion: #Is there code for X? > Existence of a subsequence that tendsto liminf


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

PR summary 8db507d0c2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ClusterPt.le_limsSup
+ ClusterPt.limsInf
+ ClusterPt.limsInf_le
+ ClusterPt.limsSup
+ FirstCountableTopology.tendsto_subseq
+ MapClusterPt.le_limsup
+ MapClusterPt.liminf
+ MapClusterPt.liminf_le
+ MapClusterPt.limsup
+ _root_.ClusterPt.exists_seq_tendsto
+ _root_.MapClusterPt.exists_seq_tendsto
+ _root_.MapClusterPt.tendsto_subseq
+ exists_seq_comp_tendsto
+ exists_seq_tendsto_liminf
+ exists_seq_tendsto_limsInf
+ exists_seq_tendsto_limsSup
+ exists_seq_tendsto_limsup
+ isGreatest_clusterPt_limsSup
+ isGreatest_mapClusterPt_limsup
+ isLeast_clusterPt_limsInf
+ isLeast_mapClusterPt_liminf
- tendsto_subseq

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
6903 2 backward.isDefEq.respectTransparency

Current commit 88f412906a
Reference commit 8db507d0c2

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Mar 28, 2026
Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

While you're at it, could you (in this PR or the next one) show that the limsInf of a (suitably bounded) filter is its least cluster point ? You've just proven that it is a cluster point, and then you can get that it's smaller than any cluster point using Filter.limsInf_le_limsInf_of_le and limsInf_eq_of_le_nhds.

@ADedecker ADedecker added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 29, 2026
@CoolRmal
Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 29, 2026
Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, this looks very good. I think this will be the last round of review but I'll have a final look once you've made these changes.

@ADedecker ADedecker added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 30, 2026
@CoolRmal
Copy link
Copy Markdown
Contributor Author

CoolRmal commented Apr 3, 2026

-awaiting-author

@ADedecker Sorry for the delay. I think I’ve addressed all your comments. Could you take another look at this PR when you have time?

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this looks very nice! Could you expand the PR description a bit?

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 3, 2026

✌️ CoolRmal can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Apr 3, 2026
@CoolRmal
Copy link
Copy Markdown
Contributor Author

CoolRmal commented Apr 3, 2026

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 3, 2026
#37296)

The PR establishes the following results:

1. The `limsSup` of a filter `f` is a cluster point of `f`, and in fact it is the greatest cluster point of `f`.
2. If `f` is a countably generated filter in a first countable space, then there exists a sequence converging to `limsSup f`.
3. Analogous statements for `limsup` are also proved.
4. Analogous statements for  `limsInf` and `liminf` are also proved.

Zulip discussion: [#Is there code for X? > Existence of a subsequence that tendsto liminf](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Existence.20of.20a.20subsequence.20that.20tendsto.20liminf/with/582207405)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 3, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Order): existence of a sequence that converges to limsup [Merged by Bors] - feat(Topology/Order): existence of a sequence that converges to limsup Apr 3, 2026
@mathlib-bors mathlib-bors bot closed this Apr 3, 2026
@CoolRmal CoolRmal deleted the liminfsubseq branch April 3, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants