Skip to content

chore(Order/Defs/Unbundled): deprecate def Reflexive in favor of class Std.Refl#37278

Open
SnirBroshi wants to merge 3 commits intoleanprover-community:masterfrom
SnirBroshi:chore/relation-duplication/reflexive
Open

chore(Order/Defs/Unbundled): deprecate def Reflexive in favor of class Std.Refl#37278
SnirBroshi wants to merge 3 commits intoleanprover-community:masterfrom
SnirBroshi:chore/relation-duplication/reflexive

Conversation

@SnirBroshi
Copy link
Copy Markdown
Collaborator

Also adds definitional lemmas std*_def for the relation classes, and cleans up things nearby, especially in Logic/Relation.lean.


Mathlib's def Reflexive
Core's class Std.Refl

Zulip

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

PR summary 55b0702ef4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Equivalence.stdRefl
+ LiftRelO.refl
+ Std.Refl.comap
+ Std.Refl.ne_imp_iff
+ Std.Refl.rel_of_ne_imp
+ _root_.IsTrans.map
+ _root_.Std.Refl.map
+ _root_.Std.Refl.set_pairwise_iff
+ antisymm_def
+ asymm_def
+ irrefl_def
+ refl
+ refl_def
+ refl_iff_subrelation_eq
+ stdRefl_manyOneReducible
+ stdRefl_oneOneReducible
+ symm_def
+ total_def
+ transGen_of_pred_of_refl
+ transGen_of_succ_of_refl
+ trichotomous_def
++-- LiftRel.refl
++-- LiftRel.trans
- _root_.Reflexive.set_pairwise_iff
--++ LiftRel.equiv

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@SnirBroshi
Copy link
Copy Markdown
Collaborator Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 27, 2026

Benchmark results for bada9c8 against 55b0702 are in. There are no significant changes. @SnirBroshi

  • build//instructions: -486.5M (-0.00%)

Small changes (1✅)

  • build/module/Mathlib.Lean.Name//instructions: -238.4M (-7.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants