Skip to content

perf(Tactic/Abel): use mkAuxTheorem for proof term#37214

Open
Kha wants to merge 1 commit intoleanprover-community:masterfrom
Kha:push-kotpqmxqwksn
Open

perf(Tactic/Abel): use mkAuxTheorem for proof term#37214
Kha wants to merge 1 commit intoleanprover-community:masterfrom
Kha:push-kotpqmxqwksn

Conversation

@Kha
Copy link
Copy Markdown
Collaborator

@Kha Kha commented Mar 26, 2026

Removes some duplication from types of nested proofs

@Kha
Copy link
Copy Markdown
Collaborator Author

Kha commented Mar 26, 2026

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 26, 2026

Benchmark results for e7841ff against 6b84688 are in. There are no significant changes. @Kha

  • build//instructions: -41.0G (-0.02%)

Small changes (1✅)

  • build/module/Mathlib.Algebra.Lie.Cochain//instructions: -5.0G (-6.81%)

@github-actions
Copy link
Copy Markdown

PR summary 6b8468855c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-meta Tactics, attributes or user commands label Mar 26, 2026
@Kha Kha marked this pull request as ready for review March 26, 2026 15:18
@JovanGerb
Copy link
Copy Markdown
Contributor

Is there a reason to do this for abel specifically? What about ring?

@Kha
Copy link
Copy Markdown
Collaborator Author

Kha commented Mar 28, 2026

Is there a reason to do this for abel specifically? What about ring?

Only that there was no direct indication it would help with others, maybe worth a try. But also these savings here may be too small to even bother with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants