Skip to content

chore(Geometry/Convex/Cone/Pointed): clean up variables#37191

Open
artie2000 wants to merge 6 commits intoleanprover-community:masterfrom
artie2000:pointedcone_cleanup
Open

chore(Geometry/Convex/Cone/Pointed): clean up variables#37191
artie2000 wants to merge 6 commits intoleanprover-community:masterfrom
artie2000:pointedcone_cleanup

Conversation

@artie2000
Copy link
Copy Markdown
Collaborator

@artie2000 artie2000 commented Mar 26, 2026 •
edited
Loading

  • Remove variable overwrites by changing variable declarations and renaming variables
  • Rename variables to maintain rough type-consistency within the file
  • Reorganise sections in order of increasing typeclass strength
  • Bring explicit/implicit variables in line with convention

This PR doesn't change any declarations beyond changing variable explicitness.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026 •
edited
Loading

PR summary e960b84129

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : CanLift (ConvexCone R M) (PointedCone R M) (↑) ConvexCone.Pointed
+ instance : Coe (PointedCone R M) (ConvexCone R M)
+ instance : Coe (Submodule R M) (PointedCone R M) := ⟨ofSubmodule⟩
- instance : CanLift (ConvexCone R E) (PointedCone R E) (↑) ConvexCone.Pointed
- instance : Coe (PointedCone R E) (ConvexCone R E)
- instance : Coe (Submodule R E) (PointedCone R E) := ⟨ofSubmodule⟩

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-convex-geometry Affine geometry, cones, simplices label Mar 26, 2026
@artie2000
Copy link
Copy Markdown
Collaborator Author

artie2000 commented Mar 26, 2026

@martinwintermath

@artie2000 artie2000 changed the title chore(Geometry/Convex/Cone): clean up variables in PointedCone.lean chore(Geometry/Convex/Cone/Pointed): clean up variables Mar 26, 2026
@martinwintermath
Copy link
Copy Markdown
Contributor

martinwintermath commented Mar 26, 2026

Could we take this chance to rename the module E to M like it is in most other files?

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 27, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

mathlib-merge-conflicts bot commented Mar 27, 2026

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

t-convex-geometry Affine geometry, cones, simplices

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artie2000 @martinwintermath