[Merged by Bors] - chore(LinearAlgebra/Matrix): generalize equivs and use where#37178
Closed
SnirBroshi wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(LinearAlgebra/Matrix): generalize equivs and use where#37178SnirBroshi wants to merge 1 commit intoleanprover-community:masterfrom
where#37178SnirBroshi wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 36653f0972Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Collaborator
|
!bench |
|
Benchmark results for d1757f2 against 36653f0 are in. There are no significant changes. @vihdzp
Small changes (1🟥)
|
1 task
j-loreaux
reviewed
Mar 26, 2026
Contributor
j-loreaux
left a comment
j-loreaux
left a comment
There was a problem hiding this comment.
Given that the benchmarking for this was fine, I'm okay with it.
bors merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
- Generalize `Matrix.compAddEquiv` from `AddCommMonoid` to `Add` - Generalize `Matrix.transposeRingEquiv` from `CommSemigroup` to `CommMagma` - Generalize `Matrix.conjTransposeRingEquiv` from `Semiring` to `NonUnitalNonAssocSemiring`
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
wherewhere
justus-springer
pushed a commit
to justus-springer/mathlib4
that referenced
this pull request
Mar 28, 2026
…rover-community#37178) - Generalize `Matrix.compAddEquiv` from `AddCommMonoid` to `Add` - Generalize `Matrix.transposeRingEquiv` from `CommSemigroup` to `CommMagma` - Generalize `Matrix.conjTransposeRingEquiv` from `Semiring` to `NonUnitalNonAssocSemiring`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matrix.compAddEquivfromAddCommMonoidtoAddMatrix.transposeRingEquivfromCommSemigrouptoCommMagmaMatrix.conjTransposeRingEquivfromSemiringtoNonUnitalNonAssocSemiring