Skip to content

[Merged by Bors] - feat(CStarAlgebra): Ring.inverse is convex and antitone on strictly positive operators#37009

Closed
dupuisf wants to merge 29 commits intoleanprover-community:masterfrom
dupuisf:convexOn_ringInverse
Closed

[Merged by Bors] - feat(CStarAlgebra): Ring.inverse is convex and antitone on strictly positive operators#37009
dupuisf wants to merge 29 commits intoleanprover-community:masterfrom
dupuisf:convexOn_ringInverse

Conversation

@dupuisf
Copy link
Copy Markdown
Contributor

@dupuisf dupuisf commented Mar 23, 2026

This PR shows that the inverse is operator convex and operator antitone (we had the latter for inverse of elements in Units, but not for Ring.inverse).


Open in Gitpod

@dupuisf dupuisf added WIP Work in progress t-analysis Analysis (normed *, calculus) labels Mar 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

PR summary db1186dd23

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Analysis.SpecialFunctions.ContinuousFunctionalCalculus.Rpow.ConjSqrt (new file) 2308
Mathlib.Analysis.SpecialFunctions.ContinuousFunctionalCalculus.Rpow.RingInverseOrder (new file) 2691

Declarations diff

+ Ring.inverse_mul
+ _root_.IsStrictlyPositive.isUnit_cfcSqrt
+ _root_.IsStrictlyPositive.ringInverse
+ _root_.IsUnit.isStrictlyPositive_iff_conjugate_of_isSelfAdjoint
+ _root_.isSelfAdjoint_ringInverse_iff
+ _root_.isStrictlyPositive_ringInverse_iff
+ antitoneOn_ringInverse
+ cfc_rpow
+ commute_of_mul_eq_isSelfAdjoint
+ conjSqrt
+ conjSqrt_apply
+ conjSqrt_conjSqrt_ringInverse
+ conjSqrt_le_conjSqrt
+ conjSqrt_monotone
+ conjSqrt_of_not_nonneg
+ conjSqrt_one
+ conjSqrt_ringInverse_conjSqrt
+ conjSqrt_ringInverse_self
+ conjugate_of_isUnit_of_isSelfAdjoint
+ convexOn_ringInverse
+ inverse_inverse
+ isStrictlyPositive_conjSqrt_iff
+ isUnit_sqrt_iff_isStrictlyPositive
+ mul_left_iff
+ mul_right_iff
+ of_subsingleton
+ ringInverse
+ ringInverse_conjSqrt
+ ringInverse_le_ringInverse
+ ringInverse_nonneg_iff_nonneg_of_isUnit
+ sqrt_of_not_nonneg
+ sqrt_ringInverse
+ toLinearMap_conjSqrt
- Ring.inverse_inverse
- _root_.IsUnit.cfcSqrt

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
6897 1 backward.isDefEq.respectTransparency

Current commit 50e125b400
Reference commit db1186dd23

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@dupuisf dupuisf removed the WIP Work in progress label Mar 23, 2026
@dupuisf dupuisf requested a review from j-loreaux March 23, 2026 04:24
@themathqueen
Copy link
Copy Markdown
Collaborator

I suspect a lot of these proofs can be golfed a lot. I can give it a shot sometime this week, unless you want to?

@dupuisf
Copy link
Copy Markdown
Contributor Author

dupuisf commented Mar 23, 2026

I suspect a lot of these proofs can be golfed a lot. I can give it a shot sometime this week, unless you want to?

Feel free to give it a shot!

Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have more to say for the later files, but this is a start. Also, I just sent your ⁻¹ʳ notation PR to bors recently, so you should merge master and use that notation once it's available.

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 23, 2026
@github-actions github-actions bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 25, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 25, 2026
@dupuisf dupuisf removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 25, 2026
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do the other two files over the weekend.

Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got bored so here are the rest of my comments

Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final comments from me

Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you need to merge master again? But looks good

Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes me so happy that all of this now Just Works. 😃

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 1, 2026

✌️ dupuisf can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Apr 1, 2026
@dupuisf
Copy link
Copy Markdown
Contributor Author

dupuisf commented Apr 1, 2026

bors r+

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 1, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 1, 2026
… positive operators (#37009)

This PR shows that the inverse is operator convex and operator antitone (we had the latter for inverse of elements in `Units`, but not for `Ring.inverse`).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 1, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CStarAlgebra): Ring.inverse is convex and antitone on strictly positive operators [Merged by Bors] - feat(CStarAlgebra): Ring.inverse is convex and antitone on strictly positive operators Apr 1, 2026
@mathlib-bors mathlib-bors bot closed this Apr 1, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 3, 2026
… positive operators (leanprover-community#37009)

This PR shows that the inverse is operator convex and operator antitone (we had the latter for inverse of elements in `Units`, but not for `Ring.inverse`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants