Skip to content

chore(Topology/Order/Basic): use Preorder.topology in OrderTopology#36958

Open
JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-OrderTopology
Open

chore(Topology/Order/Basic): use Preorder.topology in OrderTopology#36958
JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-OrderTopology

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb commented Mar 21, 2026 •
edited
Loading

This PR addresses the comment:

TODO: define `Preorder.topology` before `OrderTopology` and reuse the def

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2026 •
edited
Loading

PR summary 10214d2e22

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ LinearOrder.bot_topologicalSpace_eq_preorderTopology
+ instance [t : OrderTopology α] : OrderTopology αᵒᵈ := by
- instance [t : OrderTopology α] : OrderTopology αᵒᵈ

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
8725 -1 backward.isDefEq

Current commit efcfeba27d
Reference commit 10214d2e22

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vihdzp vihdzp vihdzp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PatrickMassot PatrickMassot

Labels

t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JovanGerb @vihdzp @PatrickMassot