Skip to content

chore(ModelTheory/Types): expose T in typesWith and move it to Theory#36955

Open
NoneMore wants to merge 1 commit intoleanprover-community:masterfrom
NoneMore:fix/typeswith-explicit-theory
Open

chore(ModelTheory/Types): expose T in typesWith and move it to Theory#36955
NoneMore wants to merge 1 commit intoleanprover-community:masterfrom
NoneMore:fix/typeswith-explicit-theory

Conversation

@NoneMore
Copy link
Copy Markdown
Contributor

@NoneMore NoneMore commented Mar 21, 2026

Make the T : L.Theory argument explicit in typesWith and place the definition in FirstOrder.Language.Theory to enable dot notation.

Open in Gitpod

@NoneMore NoneMore changed the title chore(ModelTheory/Type): expose T in typesWith and move it to Theory chore(ModelTheory/Types): expose T in typesWith and move it to Theory Mar 21, 2026
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Mar 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2026

PR summary 57c0c3e81e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-logic Logic (model theory, etc) label Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-logic Logic (model theory, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NoneMore