Skip to content

[Merged by Bors] - chore: rename arguments of Cardinal.inductionOn#36929

Closed
vihdzp wants to merge 2 commits intoleanprover-community:masterfrom
vihdzp:card
Closed

[Merged by Bors] - chore: rename arguments of Cardinal.inductionOn#36929
vihdzp wants to merge 2 commits intoleanprover-community:masterfrom
vihdzp:card

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Mar 21, 2026

So we can use as induction c using Cardinal.inductionOn with | mk α.


Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. t-set-theory Set theory labels Mar 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2026

PR summary e42eb8d4a6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@JovanGerb
Copy link
Copy Markdown
Contributor

Seems reasonable to me. As an aside: shouldn't we be using cases c using Cardinal.inductionOn with | mk α?

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by JovanGerb.


issue_comment, wf_run

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 21, 2026
@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Mar 21, 2026

I guess cases and induction do the same thing here, huh. That seems like something we could have a linter for!

Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 21, 2026

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 21, 2026
@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Mar 21, 2026

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 21, 2026
So we can use as `induction c using Cardinal.inductionOn with | mk α`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 21, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: rename arguments of Cardinal.inductionOn [Merged by Bors] - chore: rename arguments of Cardinal.inductionOn Mar 21, 2026
@mathlib-bors mathlib-bors bot closed this Mar 21, 2026
justus-springer pushed a commit to justus-springer/mathlib4 that referenced this pull request Mar 28, 2026
…ty#36929)

So we can use as `induction c using Cardinal.inductionOn with | mk α`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants