[Merged by Bors] - feat(Order/Cofinal): a set is cofinal iff the union of all Iic/Iio intervals is the entire set#36927
Closed
vihdzp wants to merge 3 commits intoleanprover-community:masterfrom
Closed
Conversation
Collaborator
vihdzp
commented
Mar 21, 2026
vihdzp
commented
3 tasks
github-actions
bot
added
the
large-import
PR summary e42eb8d4a6Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Order.Cofinal | 241 | 247 | +6 (+2.49%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Order.Cofinal |
6 |
Declarations diff
+ isCofinal_iff_iUnion_Iic_eq_univ
+ isCofinal_iff_iUnion_Iio_eq_univ
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
JovanGerb
reviewed
Mar 21, 2026
Contributor
JovanGerb
left a comment
JovanGerb
left a comment
There was a problem hiding this comment.
I'm a bit puzzled by why we would make isCofinal_of_iUnion_Iio_eq a public lemma, but not isCofinal_of_iUnion_Iic_eq. Isn't the latter a "stronger" lemma, so easier to use? So I would suggest to inline the proof of isCofinal_of_iUnion_Iio_eq.
Also, I find the names ending in _eq slightly awkard. Maybe extend them to _eq_univ?
Contributor
|
Thanks! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by JovanGerb. |
mathlib-triage
bot
added
the
maintainer-merge
YaelDillies
approved these changes
Mar 21, 2026
Contributor
YaelDillies
left a comment
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks! 🚀
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Contributor
|
Thanks! bors merge |
mathlib-triage
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2026
…` intervals is the entire set (#36927)
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
mathlib-bors
bot
changed the title
Iic/Iio intervals is the entire setIic/Iio intervals is the entire set
justus-springer
pushed a commit
to justus-springer/mathlib4
that referenced
this pull request
Mar 28, 2026
…` intervals is the entire set (leanprover-community#36927)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.