Skip to content

feat(Algebra/Ring/Subsemiring): subsemiring support#36863

Open
artie2000 wants to merge 2 commits intoleanprover-community:masterfrom
artie2000:subsemiring_support
Open

feat(Algebra/Ring/Subsemiring): subsemiring support#36863
artie2000 wants to merge 2 commits intoleanprover-community:masterfrom
artie2000:subsemiring_support

Conversation

@artie2000
Copy link
Copy Markdown
Collaborator

@artie2000 artie2000 commented Mar 19, 2026

  • Add automation for working with support of a subsemiring
  • Define structure for support of a subsemiring when it's an ideal
  • Prove sufficient condition for it to be an ideal

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

PR summary db6ec05280

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Ring.Subsemiring.Support (new file) 1108

Declarations diff

+ HasIdealSupport
+ _root_.AddSubmonoid.IsSpanning.hasIdealSupport
+ eq_zero_of_mem_of_neg_mem
+ eq_zero_of_mem_of_neg_mem₂
+ hasIdealSupport_iff
+ mem_or_neg_mem
+ mem_support
+ neg_smul_mem
+ smul_mem
+ support
+ toAddSubmonoid_support

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 19, 2026
@artie2000 artie2000 requested a review from vihdzp March 23, 2026 15:16
@dagurtomas dagurtomas removed their assignment Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants