Skip to content

doc(Geometry): tidy bibliography entry#36856

Open
harahu wants to merge 1 commit intoleanprover-community:masterfrom
harahu:roigdominguez
Open

doc(Geometry): tidy bibliography entry#36856
harahu wants to merge 1 commit intoleanprover-community:masterfrom
harahu:roigdominguez

Conversation

@harahu
Copy link
Copy Markdown
Contributor

@harahu harahu commented Mar 19, 2026

@harahu harahu changed the title doc: tidy bibliography entry doc(Geometry): tidy bibliography entry Mar 19, 2026
@github-actions github-actions bot added the t-differential-geometry Manifolds etc label Mar 19, 2026
@github-actions
Copy link
Copy Markdown

PR summary 05a5af1841

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@harahu harahu marked this pull request as ready for review March 19, 2026 15:23
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Mar 19, 2026

Thanks for your PR and for cleaning up the .bib entry I added. I tried following the links in your PR description, and mostly don't see how they support your point though. Can you double-check, please? (They could be AI-hallucinated; I've seen this before. And they do look plausible, so you really need to check.)

@grunweg grunweg added awaiting-author A reviewer has asked the author a question or requested changes. LLM-generated PRs with substantial input from LLMs - review accordingly labels Mar 19, 2026
@harahu
Copy link
Copy Markdown
Contributor Author

harahu commented Mar 19, 2026

Thanks for asking! I did check the links before publishing the PR, but I agree that I didn't communicate what the links were showing very well. Let me give it another try:

The first two links (https://fama.iff.csic.es/personas/margalef/margalef.html, https://produccioncientifica.ucm.es/investigadores/166066/tesis) are institutional pages that use the spelling of the author names that I propose, "Margalef Roig" and "Domínguez", respectively.

The next two links (https://books.google.com/books/about/Differential_Topology.html?id=gexAr04vRT4C, https://books.google.com/books/about/Topolog%C3%ADa_diferencial.html?id=0PRMy3ffm4QC) are Google books entries for the original Spanish version of the book and the English version from 1992 that you cite. They show that the title of the book is "Differential Topology" in the English version and "Topología diferencial" in the original Spanish, which justifies the change to the title field. The 5th page of the Spanish version, as shown on the page, also supports the author name spelling I'm proposing.

The fifth link (https://search.worldcat.org/title/Differential-topology/oclc/25713102), claims the publisher is "North-Holland, Amsterdam" and again repeats the author names that I suggest.

The final link (https://www.ams.org/tran/2010-362-08/S0002-9947-10-05073-7/) references this same book (see under references) and uses "North-Holland Publishing Co., Amsterdam" as the publisher.

In conclusion: I think the changes to the author names are well-evidenced. The same is true for the title change.

The evidence for the change to the publisher field is perhaps a bit less clear-cut. You could make the case that "North-Holland, Amsterdam" would be tidier, or even "Elsevier", since North-Holland had been acquired by Elsevier already in 1970.

I still think "North-Holland Publishing Co." is cleaner than "North-Holland" alone, though, as the latter is easy to misread as a toponym. Also, "North-Holland Publishing Co." is already used in Mathlib (see ref. MR0302656) and is referenced elsewhere (see the final link above, but also https://en.wikipedia.org/wiki/Elsevier and https://www.wikidata.org/wiki/Q19960298).

@harahu
Copy link
Copy Markdown
Contributor Author

harahu commented Mar 19, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LLM-generated PRs with substantial input from LLMs - review accordingly t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants