Skip to content

feat(RingTheory/Localization): Nagata's criterion for primality in localization away#36785

Open
hommmmm wants to merge 4 commits intoleanprover-community:masterfrom
hommmmm:Nagata-primality
Open

feat(RingTheory/Localization): Nagata's criterion for primality in localization away#36785
hommmmm wants to merge 4 commits intoleanprover-community:masterfrom
hommmmm:Nagata-primality

Conversation

@hommmmm
Copy link
Copy Markdown

@hommmmm hommmmm commented Mar 18, 2026

Summary

  • Add dvd_of_mem_span_singleton_localization: if p is prime and p ∤ x, then
    membership in the span of the image of x in R[1/p] implies divisibility by x.
  • Add prime_of_prime_in_localization (Nagata's criterion): if p is prime, x is
    irreducible, and the image of x in R[1/p] is prime, then x is prime.

References

AI Disclosure

This code is written without AI, then uses Claude Code with cameronfreer's Lean4-skills (specifically, the review, refactor, and golf workflow) for style changes, refactoring and golfing.


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Mar 18, 2026
@github-actions
Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

PR summary 316a0377d0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.Localization.Away.Prime (new file) 1135

Declarations diff

+ dvd_of_mem_span_singleton_localization
+ prime_of_prime_in_localization

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Mar 18, 2026
@chrisflav
Copy link
Copy Markdown
Member

Welcome! Could you please clarify if and how you used AI for (parts of) this pull request? Note that our contribution guidelines require disclosure of any AI assistance.
Please note that this message does not say anything about your PR in particular, this is just a regular question we ask on PRs by new contributors.

@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 22, 2026
@hommmmm
Copy link
Copy Markdown
Author

hommmmm commented Mar 22, 2026

Welcome! Could you please clarify if and how you used AI for (parts of) this pull request? Note that our contribution guidelines require disclosure of any AI assistance. Please note that this message does not say anything about your PR in particular, this is just a regular question we ask on PRs by new contributors.

Updated PR message with AI disclosure

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants