Skip to content

chore: golf using grind#36740

Open
euprunin wants to merge 1 commit intoleanprover-community:masterfrom
euprunin:golf-dcxxxvi
Open

chore: golf using grind#36740
euprunin wants to merge 1 commit intoleanprover-community:masterfrom
euprunin:golf-dcxxxvi

Conversation

@euprunin
Copy link
Copy Markdown
Contributor

The goal of this PR is to decrease the number of times lemmas are called explicitly. Any decrease in compilation time is a welcome side effect, although it is not a primary objective.

Trace profiling results (differences <30 ms considered measurement noise):

  • AlgebraicGeometry.Scheme.isBasis_affineOpens: unchanged 🎉
  • SimpleGraph.Walk.takeUntil_eq_take: 263 ms before, 180 ms after 🎉
  • SimpleGraph.Walk.dropUntil_eq_drop: 382 ms before, 261 ms after 🎉
  • Int.image_Ico_emod: unchanged 🎉
  • Equiv.Perm.ofSubtype_swap_eq: unchanged 🎉

Profiled using set_option trace.profiler true in.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

PR summary 69f3b8d654

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 19, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 19, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 1, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants