Skip to content

feat(Order): OrderType.lift and more order type API#36720

Open
YanYablonovskiy wants to merge 11 commits intoleanprover-community:masterfrom
YanYablonovskiy:OrderType_lift
Open

feat(Order): OrderType.lift and more order type API#36720
YanYablonovskiy wants to merge 11 commits intoleanprover-community:masterfrom
YanYablonovskiy:OrderType_lift

Conversation

@YanYablonovskiy
Copy link
Copy Markdown
Contributor

@YanYablonovskiy YanYablonovskiy commented Mar 16, 2026

Adding the universe lifting operation to OrderType , addresses a 'TODO' .

Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Mar 16, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026 •
edited
Loading

PR summary 09d467d787

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ lift
+ lift_id
+ lift_id'
+ lift_lift.{u_1}
+ lift_type_eq_iff
+ lift_type_le_iff
+ lift_uzero
+ type_uLift

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-order Order theory label Mar 16, 2026
YaelDillies
YaelDillies reviewed Mar 16, 2026
View reviewed changes
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 16, 2026
@YanYablonovskiy
Copy link
Copy Markdown
Contributor Author

YanYablonovskiy commented Mar 16, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 16, 2026
YaelDillies
YaelDillies approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

trigger_name: pull_request_review
wf_run: workflow_run

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 16, 2026
vihdzp
vihdzp reviewed Mar 18, 2026
View reviewed changes
@vihdzp vihdzp added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 18, 2026
@jcommelin jcommelin removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 21, 2026
@YanYablonovskiy
Copy link
Copy Markdown
Contributor Author

YanYablonovskiy commented Mar 23, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 23, 2026
vihdzp
vihdzp approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM!

@YanYablonovskiy @vihdzp
Apply suggestions from code review
01029cd 
Co-authored-by: Violeta Hernández Palacios <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

+1 more reviewer

@vihdzp vihdzp vihdzp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bryangingechen bryangingechen

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-order Order theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@YanYablonovskiy @YaelDillies @vihdzp @bryangingechen @jcommelin