feat(SetTheory/Ordinal/Commute): characterize when ordinal addition commutes#36664
Open
SnirBroshi wants to merge 11 commits intoleanprover-community:masterfrom
Open
feat(SetTheory/Ordinal/Commute): characterize when ordinal addition commutes#36664SnirBroshi wants to merge 11 commits intoleanprover-community:masterfrom
SnirBroshi wants to merge 11 commits intoleanprover-community:masterfrom
Conversation
PR summary 09af23f880Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
vihdzp
reviewed
Mar 15, 2026
vihdzp
approved these changes
Mar 15, 2026
Collaborator
vihdzp
left a comment
vihdzp
left a comment
There was a problem hiding this comment.
Other than those minor nitpicks, LGTM.
1 task
mathlib-merge-conflicts
bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
github-actions
bot
removed
the
merge-conflict
Collaborator
|
In view of #36681, I think this result should be moved to a new file about commuting ordinal operations. |
vihdzp
approved these changes
Mar 21, 2026
Collaborator
vihdzp
left a comment
vihdzp
left a comment
There was a problem hiding this comment.
LGTM, just remember to update the title so it reflects the new file.
SnirBroshi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proof is from "Cardinal and Ordinal Numbers".
A similar fact for multiplication is mentioned on Wikipedia.