Skip to content

feat(RingTheory): adds two lemmas on Module.length#36657

Open
BryceT233 wants to merge 10 commits intoleanprover-community:masterfrom
BryceT233:lemmas_length
Open

feat(RingTheory): adds two lemmas on Module.length#36657
BryceT233 wants to merge 10 commits intoleanprover-community:masterfrom
BryceT233:lemmas_length

Conversation

@BryceT233
Copy link
Copy Markdown
Contributor

This PR adds two lemmas regarding the length of modules:

  • Submodule.length_le_restrictScalar shows that the length of an $R$-submodule is less than or equal to its length as an $A$-submodule under scalar restriction.
  • Submodule.length_quotient_lt shows that for a module of finite length, the length of a quotient module $M \big/ p$ is strictly less than the length of $M$ when the submodule $p$ is non-trivial.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 15, 2026

PR summary b301d257a1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Submodule.length_le_length_restrictScalar
+ Submodule.length_quotient_lt
+ lt_add_left

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Mar 15, 2026
@WenrongZou
Copy link
Copy Markdown
Contributor

awaiting-author

@github-actions github-actions bot added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 1, 2026
@BryceT233
Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 1, 2026
@WenrongZou
Copy link
Copy Markdown
Contributor

LGTM! Thanks!

Copy link
Copy Markdown
Contributor

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comments, but LGTM otherwise

@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
@BryceT233
Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants