Skip to content

[Merged by Bors] - chore(Algebra/Order/Monoid/Unbundled/Basic): replace mul_left_cancel'' with an IsLeftCancelMul instance#36629

Closed
SnirBroshi wants to merge 2 commits intoleanprover-community:masterfrom
SnirBroshi:chore/order/deprecate-mul-left-cancel-prime-prime
Closed

[Merged by Bors] - chore(Algebra/Order/Monoid/Unbundled/Basic): replace mul_left_cancel'' with an IsLeftCancelMul instance#36629
SnirBroshi wants to merge 2 commits intoleanprover-community:masterfrom
SnirBroshi:chore/order/deprecate-mul-left-cancel-prime-prime

Conversation

@SnirBroshi
Copy link
Copy Markdown
Collaborator

@SnirBroshi SnirBroshi commented Mar 14, 2026 •
edited
Loading

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 14, 2026 •
edited
Loading

PR summary 7c885dc01c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ add_left_cancel''
+ add_right_cancel''
+ instance [MulLeftReflectLE α] : IsLeftCancelMul α
+ instance [MulRightReflectLE α] : IsRightCancelMul α

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 14, 2026
@joelriou
Copy link
Copy Markdown
Contributor

joelriou commented Mar 30, 2026

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 30, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 30, 2026
@SnirBroshi
chore(Algebra/Order/Monoid/Unbundled/Basic): replace `mul_left_cancel…
a4cbabc 
…''` with an `IsLeftCancelMul` instance (#36629)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 30, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Order/Monoid/Unbundled/Basic): replace mul_left_cancel'' with an IsLeftCancelMul instance [Merged by Bors] - chore(Algebra/Order/Monoid/Unbundled/Basic): replace mul_left_cancel'' with an IsLeftCancelMul instance Mar 30, 2026
@mathlib-bors mathlib-bors bot closed this Mar 30, 2026
@SnirBroshi SnirBroshi mentioned this pull request Mar 30, 2026
Open
aditya-ramabadran pushed a commit to aditya-ramabadran/mathlib4 that referenced this pull request Apr 1, 2026
@SnirBroshi @aditya-ramabadran
chore(Algebra/Order/Monoid/Unbundled/Basic): replace `mul_left_cancel…
acc3b66 
…''` with an `IsLeftCancelMul` instance (leanprover-community#36629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joelriou joelriou

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SnirBroshi @joelriou