feat(Translate): reorder universes#36604
feat(Translate): reorder universes#36604JovanGerb wants to merge 18 commits intoleanprover-community:masterfrom
Conversation
|
This pull request is now in draft mode. No active bors state needed cleanup. While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like |
PR summary b301d257a1Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
This pull request has conflicts, please merge |
|
Oh oops, I forgot to remove the draft status. |
|
Could you add some tests? |
|
This pull request has conflicts, please merge |
|
This pull request has conflicts, please merge |
This PR improves the heuristic for reordering of universes in
to_dual/to_additive. The previous heuristic worked well when the first two universes had to be swapped. For example for translatinga ^ nton • a, and for dualizingGaloisConnection. However, in Category theory we sometimes need to swap more universes because a category instance comes with 2 universes which both need to be swapped. In particular, the comma category, and adjunctions both need this feature.This PR doesn't add any syntax for specifying the reordering of universes. It is assumed that the universe reordering can always be inferred from the normal reordering and from the type.