Skip to content

[Merged by Bors] - feat(Algebra/Homology/SpectralObject): the spectral sequence#36555

Closed
joelriou wants to merge 139 commits intoleanprover-community:masterfrom
joelriou:spectral-sequences-2-spectral-sequence-2
Closed

[Merged by Bors] - feat(Algebra/Homology/SpectralObject): the spectral sequence#36555
joelriou wants to merge 139 commits intoleanprover-community:masterfrom
joelriou:spectral-sequences-2-spectral-sequence-2

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Mar 12, 2026

joelriou and others added 30 commits February 15, 2026 16:39
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 27, 2026
justus-springer pushed a commit to justus-springer/mathlib4 that referenced this pull request Mar 28, 2026
…he spectral sequence (leanprover-community#36550)

If `X` is a spectral object indexed by the preordered type `ι` in the abelian category `C` and we have a recipe `data : SpectralSequenceDataCore ι c r₀`, we define the pages of the spectral sequences attached to `X` and `data`, and we compute the kernel of the differentials. In the next PR leanprover-community#36555 in the series, the spectral sequence shall be constructed in full.
Copy link
Copy Markdown
Contributor

@dagurtomas dagurtomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth thinking about what is supposed to be the user-facing API here. Many of the lemmas seem to be auxiliary and only to be used in constructions in this file. Do we really want this whole file as an @[expose] public section?

@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
@joelriou
Copy link
Copy Markdown
Contributor Author

joelriou commented Apr 2, 2026

It's worth thinking about what is supposed to be the user-facing API here. Many of the lemmas seem to be auxiliary and only to be used in constructions in this file. Do we really want this whole file as an @[expose] public section?

Probably because of the data involved, I was not able to make private the definitions in the beginning of the file, but I have managed to make the main definition SpectralObject.spectralSequence irreducible.

@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
@dagurtomas
Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 2, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 4, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 4, 2026
This PR constructs the spectral sequence attached to a spectral object in an abelian category.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 4, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Homology/SpectralObject): the spectral sequence [Merged by Bors] - feat(Algebra/Homology/SpectralObject): the spectral sequence Apr 4, 2026
@mathlib-bors mathlib-bors bot closed this Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants