Skip to content

feat: add instances for IsMulCommutative s.toWeakerSubobject#36552

Open
j-loreaux wants to merge 12 commits intoleanprover-community:masterfrom
j-loreaux:IsMulCommutative-toWeakerSubobject
Open

feat: add instances for IsMulCommutative s.toWeakerSubobject#36552
j-loreaux wants to merge 12 commits intoleanprover-community:masterfrom
j-loreaux:IsMulCommutative-toWeakerSubobject

Conversation

@j-loreaux
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux commented Mar 12, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2026 •
edited
Loading

PR summary d194281a48

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ isMulCommutative_toNonUnitalStarSubalgebra
+ isMulCommutative_toNonUnitalSubalgebra
+ isMulCommutative_toNonUnitalSubring
+ isMulCommutative_toSubalgebra
++ isMulCommutative_toNonUnitalSubsemiring
++ isMulCommutative_toSubmonoid
++ isMulCommutative_toSubsemiring
+++ isMulCommutative_toSubsemigroup

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@j-loreaux j-loreaux mentioned this pull request Mar 12, 2026
Open
3 tasks
@j-loreaux j-loreaux added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-algebra Algebra (groups, rings, fields, etc) labels Mar 12, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 13, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

mathlib-merge-conflicts bot commented Mar 13, 2026

This pull request has conflicts, please merge master and resolve them.

@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 31, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

mathlib-dependent-issues bot commented Mar 31, 2026

This PR/issue depends on:

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@j-loreaux